Skip to content

Clean Code for ua/org.eclipse.help #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akurtakov merged 1 commit into from
Jun 13, 2025
Merged

Clean Code for ua/org.eclipse.help #1943

akurtakov merged 1 commit into from
Jun 13, 2025

Conversation

@eclipse-platform-bot
Copy link
Contributor

@eclipse-platform-bot eclipse-platform-bot commented Jun 11, 2025 •
edited
Loading

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Contributor Author

eclipse-platform-bot commented Jun 11, 2025 •
edited
Loading

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ua/org.eclipse.help/META-INF/MANIFEST.MF
ua/org.eclipse.help/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From 9b261301a1f5219f884b537e8d978bafac19b22a Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Thu, 12 Jun 2025 04:03:38 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/ua/org.eclipse.help/META-INF/MANIFEST.MF b/ua/org.eclipse.help/META-INF/MANIFEST.MF
index 923435851b..6748817b1e 100644
--- a/ua/org.eclipse.help/META-INF/MANIFEST.MF
+++ b/ua/org.eclipse.help/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %help_plugin_name
 Bundle-SymbolicName: org.eclipse.help; singleton:=true
-Bundle-Version: 3.10.500.qualifier
+Bundle-Version: 3.10.600.qualifier
 Bundle-Activator: org.eclipse.help.internal.HelpPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/ua/org.eclipse.help/pom.xml b/ua/org.eclipse.help/pom.xml
index d1c6395dcb..511fca8ad9 100644
--- a/ua/org.eclipse.help/pom.xml
+++ b/ua/org.eclipse.help/pom.xml
@@ -18,6 +18,6 @@
   </parent>
   <groupId>org.eclipse.platform</groupId>
   <artifactId>org.eclipse.help</artifactId>
-  <version>3.10.500-SNAPSHOT</version>
+  <version>3.10.600-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
 </project>
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025 •
edited
Loading

Test Results

 1 893 files  ±0   1 893 suites  ±0   1h 37m 30s ⏱️ + 9m 27s
 4 381 tests ±0   4 357 ✅ ±0   24 💤 ±0  0 ❌ ±0 
13 143 runs  ±0  12 976 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 79fc407. ± Comparison against base commit 22084fa.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare mentioned this pull request Jun 11, 2025
Merged
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/ua/org.eclipse.help branch from 44ad2f7 to e333f80 Compare June 12, 2025 03:59
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/ua/org.eclipse.help branch from e2164f9 to 79fc407 Compare June 13, 2025 03:50
@akurtakov akurtakov merged commit ccf00e8 into master Jun 13, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/ua/org.eclipse.help branch June 13, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eclipse-platform-bot @akurtakov